Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump coursier to 2.1.15 & Scala to 2.13.15 #112

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Nov 6, 2024

@Gedochao Gedochao requested a review from tgodzik November 6, 2024 08:31
@Gedochao
Copy link
Contributor Author

Gedochao commented Nov 6, 2024

Resolution failed for 1 modules:
--------------------------------------------
  io.get-coursier:coursier-cli_2.12:2.1.15 
	not found: /root/.ivy2/local/io.get-coursier/coursier-cli_2.12/2.1.15/ivys/ivy.xml
	not found: https://repo1.maven.org/maven2/io/get-coursier/coursier-cli_2.12/2.1.15/coursier-cli_2.12-2.1.15.pom

🤔

@tgodzik
Copy link
Member

tgodzik commented Nov 6, 2024

https://repo1.maven.org/maven2/io/get-coursier/coursier-cli_2.12/2.1.15/coursier-cli_2.12-2.1.15.pom

I think it's no longer published for 2.12, why do we actually need it?

@tgodzik
Copy link
Member

tgodzik commented Nov 6, 2024

Ach, we publish only using 2.12, do we actually need to continue publishing the image? Should we not move it to coursier?

@tgodzik
Copy link
Member

tgodzik commented Nov 6, 2024

I guess we have two options:

  • switch to 2.13 here
  • add M1 publish to coursier

@alexarchambault is it time to move arm publishing to coursier?

@Gedochao
Copy link
Contributor Author

Gedochao commented Nov 6, 2024

@tgodzik we could move it to coursier if we gave up on the Linux arm64 launchers. We need the custom runner for that. As for the MacOS aarch64, that could already be moved, I suppose.
We track it here:

@Gedochao
Copy link
Contributor Author

Gedochao commented Nov 6, 2024

Sounds like we need to switch to 2.13 here. 🤔

@tgodzik
Copy link
Member

tgodzik commented Nov 6, 2024

We can remove the macos jobs though next coursier/coursier#3148

@Gedochao Gedochao marked this pull request as draft November 6, 2024 09:22
@tgodzik
Copy link
Member

tgodzik commented Nov 6, 2024

java.lang.UnsupportedClassVersionError: coursier/bootstrap/launcher/Launcher has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0

We need to switch to JDK 17 (or wait for next release, though it's native image so it's not necessary to publish on JDK 8)

@Gedochao Gedochao force-pushed the update/coursier_2.1.15 branch from 11ef717 to ba8bff4 Compare November 6, 2024 09:39
@Gedochao Gedochao force-pushed the update/coursier_2.1.15 branch from ba8bff4 to 255444d Compare November 6, 2024 09:43
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Gedochao Gedochao marked this pull request as ready for review November 6, 2024 09:49
@Gedochao Gedochao changed the title Bump coursier to 2.1.15 Bump coursier to 2.1.15 & Scala to 2.13.15 Nov 6, 2024
@Gedochao Gedochao merged commit 2b85b6b into VirtusLab:main Nov 6, 2024
4 checks passed
@Gedochao Gedochao deleted the update/coursier_2.1.15 branch November 6, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants